Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Remove DEFAULT_UNIVERSE from BaseExternalClient #1673

Open
danielbankhead opened this issue Oct 12, 2023 · 0 comments · May be fixed by #1690
Open

refactor!: Remove DEFAULT_UNIVERSE from BaseExternalClient #1673

danielbankhead opened this issue Oct 12, 2023 · 0 comments · May be fixed by #1690
Labels
Breaking Change good first issue This issue is a good place to started contributing to this repository. next major: breaking change this is a change that we should wait to bundle into the next major version priority: p3 Desirable enhancement or fix. May not be included in next release. semver: major Hint for users that this is an API breaking change. type: cleanup An internal cleanup or hygiene concern.

Comments

@danielbankhead
Copy link
Contributor

danielbankhead commented Oct 12, 2023 •
edited
Loading

It was moved to AuthClient as of:
@danielbankhead danielbankhead added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. semver: major Hint for users that this is an API breaking change. good first issue This issue is a good place to started contributing to this repository. priority: p3 Desirable enhancement or fix. May not be included in next release. next major: breaking change this is a change that we should wait to bundle into the next major version type: cleanup An internal cleanup or hygiene concern. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Oct 12, 2023
@danielbankhead danielbankhead changed the title feat!: Remove DEFAULT_UNIVERSE from BaseExternalClient refactor!: Remove DEFAULT_UNIVERSE from BaseExternalClient Oct 12, 2023
@danielbankhead danielbankhead removed their assignment Oct 13, 2023
@Dhoni77 Dhoni77 linked a pull request Nov 7, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking Change good first issue This issue is a good place to started contributing to this repository. next major: breaking change this is a change that we should wait to bundle into the next major version priority: p3 Desirable enhancement or fix. May not be included in next release. semver: major Hint for users that this is an API breaking change. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: remove DEFAULT_UNIVERSE from BaseExternalClient Dhoni77/google-auth-library-nodejs
1 participant
@danielbankhead