Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing namespace_packages argument from setup.py #274

Closed
calder opened this issue Jun 26, 2018 · 1 comment
Closed

Consider removing namespace_packages argument from setup.py #274

calder opened this issue Jun 26, 2018 · 1 comment
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@calder
Copy link

calder commented Jun 26, 2018

The namespace_packages argument to setup prevents google/__init__.py from being included in the Pip package, which in turn prevents Bazel rules_python from treating google as a namespace package. This makes it incompatible with the protobuf package (and any other google-rooted packages) when used under Bazel.

bazelbuild/rules_python#93 tracks adding support for namespace_packages in rules_python.

@theacodes
Copy link
Contributor

Sorry, we can't do that. There are roughly 40 packages that live under the google namespace. All of them must cooperate for this to work. Bazel needs to be fixed to support namespace packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants