Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

tune default ConnectionOptions and SessionPoolOptions values. #1077

Closed
mr-salty opened this issue Nov 18, 2019 · 2 comments
Closed

tune default ConnectionOptions and SessionPoolOptions values. #1077

mr-salty opened this issue Nov 18, 2019 · 2 comments
Labels
api: spanner Issues related to the googleapis/google-cloud-cpp-spanner API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone

Comments

@mr-salty
Copy link
Contributor

We've selected default values for the members of ConnectionOptions and SessionPoolOptions; we should spend some time examining and possibly altering the chosen defaults.

This should also feed back into the cross-language design - ideally the defaults would be consistent across client libraries (which is what we're currently doing for c++)

@mr-salty mr-salty added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Nov 18, 2019
@devjgm devjgm added this to the Spanner: GA milestone Dec 13, 2019
@google-cloud-label-sync google-cloud-label-sync bot added the api: spanner Issues related to the googleapis/google-cloud-cpp-spanner API. label Jan 29, 2020
@devjgm
Copy link
Contributor

devjgm commented Feb 20, 2020

I'm thinking this may be closeable? Thoughts @mr-salty

@mr-salty
Copy link
Contributor Author

mr-salty commented Mar 4, 2020

Yeah, let's close this. The defaults in our library are the same as other client libraries and should be suitable for that purpose. Application authors may need to change them based on the characteristics of their application, hardware, spanner config, etc.

@mr-salty mr-salty closed this as completed Mar 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: spanner Issues related to the googleapis/google-cloud-cpp-spanner API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants