You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Storage introduced credentials in the public namespace google::cloud::storage::oauth2. These credential classes are now deprecated in favor of GUAC (google::cloud::Credentials):
This is backwards. We need to map storage credentials to GUAC and use GUAC in the implementation, if we ever want to remove the deprecated credentials in google::cloud::storage::oauth2.
The text was updated successfully, but these errors were encountered:
For the record, we do not need to refactor. We can "delete" the storage::oauth2 classes by moving them into storage_internal and keeping the implementation mostly the same.
We might do this to unblock the next major release.
It is just that the resulting implementation would be unnecessarily complicated compared with using GUAC types.
Storage introduced credentials in the public namespace
google::cloud::storage::oauth2
. These credential classes are now deprecated in favor of GUAC (google::cloud::Credentials
):google-cloud-cpp/google/cloud/storage/oauth2/credentials.h
Line 45 in 80a518a
However, the storage internals are implemented in terms of
google::cloud::storage::oauth2::Credentials
.google-cloud-cpp/google/cloud/storage/client.cc
Line 50 in 80a518a
We map GUAC -> storage credentials.
google-cloud-cpp/google/cloud/storage/client_options.cc
Lines 296 to 300 in 80a518a
This is backwards. We need to map storage credentials to GUAC and use GUAC in the implementation, if we ever want to remove the deprecated credentials in
google::cloud::storage::oauth2
.The text was updated successfully, but these errors were encountered: