Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage/dataflux): address deadlock when reading from ranges #11303

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

jdnurme
Copy link
Contributor

@jdnurme jdnurme commented Dec 17, 2024

This change addresses an intermittent deadlock issue when reading from the range channel. The fix introduces a 200ms timeout on all reads off of range, opting to re-check for available work if the timeout is triggered. Since this timeout is only applied to reads off of the channel it should not introduce any new blocking behavior.

@jdnurme jdnurme requested review from a team as code owners December 17, 2024 20:59
@jdnurme jdnurme changed the title address deadlock when reading from ranges fix(dataflux): address deadlock when reading from ranges Dec 17, 2024
@tritone tritone changed the title fix(dataflux): address deadlock when reading from ranges fix(storage/dataflux): address deadlock when reading from ranges Dec 17, 2024
Copy link
Contributor

@BrennaEpp BrennaEpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Can we add a test that covers this race as well?

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Dec 18, 2024
@jdnurme jdnurme force-pushed the main branch 3 times, most recently from 070fe41 to 9ccca70 Compare December 18, 2024 18:46
@tritone tritone added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 19, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 19, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 32cbf56 into googleapis:main Dec 19, 2024
8 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants