Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging: project quota limits caused flaky TestLogsAndDelete #1589

Closed
odeke-em opened this issue Sep 20, 2019 · 2 comments
Closed

logging: project quota limits caused flaky TestLogsAndDelete #1589

odeke-em opened this issue Sep 20, 2019 · 2 comments
Assignees
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@odeke-em
Copy link
Contributor

I just noticed this in https://source.cloud.google.com/results/invocations/d1a9e995-2251-4c81-b0c5-20c5b6b87a5d/targets/tests/tests;group=logging;test=TestLogsAndDelete;row=1 originally from https://source.cloud.google.com/results/invocations/60e6edc6-d114-4400-9020-62236f37ab9e/targets/cloud-go-libraries%2Fgoogle-cloud-go%2Fcontinuous%2Fmaster/log

logging_test.go:497: deleting "GO-LOGGING-CLIENT/TEST-LOG-20190919-73553409892752-0001": 
rpc error: code = ResourceExhausted desc = Quota exceeded for quota metric 
'logging.googleapis.com/control_requests' and limit 'ControlRequestsPerMinutePerProject' of 
service 'logging.googleapis.com' for consumer 'project_number:36639933145'.

@jadekler @broady could we perhaps take a look at the quota limits and perhaps bump them up?

That Kokoro run identified a whole bunch of other flakes
Screen Shot 2019-09-19 at 7 58 19 PM

@jeanbza jeanbza added the type: cleanup An internal cleanup or hygiene concern. label Sep 20, 2019
@jeanbza jeanbza added this to the Tests clean up milestone Sep 20, 2019
@broady
Copy link
Contributor

broady commented Sep 22, 2019

Looks like the quota is already maxed out:
image

I think we can request a quota bump separately.
Should also consider using a project pool (see gimmeproj in golang-samples)

@codyoss
Copy link
Member

codyoss commented May 12, 2020

Will be fixed under #1654

@codyoss codyoss closed this as completed May 12, 2020
@freelerobot freelerobot self-assigned this Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

5 participants