Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New client library generation creates a commit without proper author email #10265

Closed
suztomo opened this issue Jan 22, 2024 · 0 comments · Fixed by #10266
Closed

New client library generation creates a commit without proper author email #10265

suztomo opened this issue Jan 22, 2024 · 0 comments · Fixed by #10266
Assignees

Comments

@suztomo
Copy link
Member

suztomo commented Jan 22, 2024

CLA didn't pass for #10264 (comment).

It's not correct to assume google.com account and GitHub user name match in https://github.com/googleapis/google-cloud-java/blob/9785f8cfd43db0a8968f086a1461242da9d16cb5/.github/workflows/generate_new_client.yaml#L114C1-L119C1

      - name: Push to branch and create PR
        run: |
          set -x
          [ -z "`git config user.email`" ] && git config --global user.email "${USERNAME:-script}@google.com"
          [ -z "`git config user.name`" ] && git config --global user.name "${USERNAME:-script}"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants