Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [privilegedaccessmanager] new module for privilegedaccessmanager #11041

Merged
merged 3 commits into from
Jul 31, 2024
Merged

feat: [privilegedaccessmanager] new module for privilegedaccessmanager #11041

merged 3 commits into from
Jul 31, 2024

Conversation

cloud-java-bot
Copy link
Collaborator

Generated by @lqiu96 via generate_new_client_hermetic_build.yaml

Command used:

python generation/new_client_hermetic_build/add-new-client-config.py add-new-client --api-shortname "privilegedaccessmanager" --name-pretty "Privileged Access Manager API" --api-description "Privileged Access Manager (PAM) helps you on your journey towards least privilege and helps mitigate risks tied to privileged access misuse orabuse. PAM allows you to shift from always-on standing privileges towards on-demand access with just-in-time, time-bound, and approval-based access elevations. PAM allows IAM administrators to create entitlements that can grant just-in-time, temporary access to any resource scope. Requesters can explore eligible entitlements and request the access needed for their task. Approvers are notified when approvals await their decision. Streamlined workflows facilitated by using PAM can support various use cases, including emergency access for incident responders, time-boxed access for developers for critical deployment or maintenance, temporary access for operators for data ingestion and audits, JIT access to service accounts for automated tasks, and more." --proto-path "google/cloud/privilegedaccessmanager/v1" --product-docs "https://cloud.google.com/java/docs/reference/google-cloud-privilegedaccessmanager/latest/overview" --rpc-docs "https://cloud.google.com/iam/docs/reference/pam/rpc"

@cloud-java-bot cloud-java-bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 30, 2024
@cloud-java-bot cloud-java-bot requested a review from a team as a code owner July 30, 2024 21:52
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 30, 2024
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Jul 30, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 65 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

suztomo
suztomo approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. The API description can be shorter.

generation_config.yaml
name_pretty: Privileged Access Manager API
product_documentation:
https://cloud.google.com/java/docs/reference/google-cloud-privilegedaccessmanager/latest/overview
api_description: Privileged Access Manager (PAM) helps you on your journey towards
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the first sentence to keep it concise, as per https://github.com/googleapis/google-cloud-java/blob/main/generation/new_client_hermetic_build/README.md#api-description-api_description

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Updated

@lqiu96
Copy link
Contributor

lqiu96 commented Jul 31, 2024

Closing and re-opening to retrigger the header check

@lqiu96 lqiu96 closed this Jul 31, 2024
@lqiu96 lqiu96 reopened this Jul 31, 2024
@lqiu96 lqiu96 closed this Jul 31, 2024
@lqiu96 lqiu96 reopened this Jul 31, 2024
@lqiu96
Copy link
Contributor

lqiu96 commented Jul 31, 2024

Failed CI from generation diff / group_id_check_for_maps_libraries (pull_request), but that should be resolved in #11047

@lqiu96 lqiu96 enabled auto-merge (squash) July 31, 2024 18:29
@lqiu96 lqiu96 merged commit 74e6a63 into main Jul 31, 2024
71 of 73 checks passed
@lqiu96 lqiu96 deleted the new-library/privilegedaccessmanager-cWo3U branch July 31, 2024 18:32
@release-please release-please bot mentioned this pull request Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqiu96 lqiu96 lqiu96 left review comments

@suztomo suztomo suztomo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cloud-java-bot @lqiu96 @suztomo