Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Automatic-Module-Name to JAR MANIFEST.MF #2586

Closed
saturnism opened this issue Nov 7, 2017 · 3 comments
Closed

Add Automatic-Module-Name to JAR MANIFEST.MF #2586

saturnism opened this issue Nov 7, 2017 · 3 comments
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@saturnism
Copy link

Configure JAR plugin to add Automatic-Module-Name for our JAR distributions. Each artifact should have its own module name.

@anthmgoogle anthmgoogle added the type: question Request for information or clarification. Not an issue. label Nov 8, 2017
@anthmgoogle
Copy link

This seems like a repo-wide infrastructure question. @saturnism @lesv @garrettjonesgoogle can you determine feasibility of this suggestion, and if feasible we can turn this into a feature request or cleanup item.

@lesv
Copy link
Contributor

lesv commented Nov 18, 2017

This is a Java 9 FR. It's a common request: grpc/grpc-java#3523, grpc/grpc-java#3522, square/ok-http#3655

It should be trivial to do, see google/guava@f2be0be#diff-e407b6f223ee6c04116a91ead9f5e100R42 for an example.

@garrettjonesgoogle garrettjonesgoogle added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: question Request for information or clarification. Not an issue. labels Jan 24, 2018
@garrettjonesgoogle garrettjonesgoogle changed the title Add Automatic-Module-Name to JAR MANFIEST.MF Add Automatic-Module-Name to JAR MANIFEST.MF Jan 24, 2018
@yihanzhen
Copy link
Contributor

Move this issue to feature request backlog and close it here. This place can still be used for discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

5 participants