Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all Maven and Gradle based library import instructions to use BOM #3190

Closed
patflynn opened this issue Apr 24, 2018 · 2 comments
Closed

Update all Maven and Gradle based library import instructions to use BOM #3190

patflynn opened this issue Apr 24, 2018 · 2 comments
Assignees
@chingor13
Labels
dependencies type: docs Improvement to the documentation for an API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@patflynn
Copy link

all the specific API readme's instruct the user to directly import the versioned dependency using
<dependency> <groupId>com.google.cloud</groupId> <artifactId>google-cloud-translate</artifactId> <version>1.27.0</version> </dependency>

This is setting users up for diamond dep conflicts as soon as they choose to import another library in the catalog.

Instead we should always instruct the user to use the BOM to import google-cloud-java libraries.
@patflynn
Copy link
Author

@GoogleCloudPlatform/cloud-tools-for-java

Garrett is accepting PRs. :) Anybody got the bandwidth to work on updating these docs?

@JustinBeckwith JustinBeckwith added 🚨 This issue needs some love. triage me I really want to be triaged. labels Jun 8, 2018
@yihanzhen yihanzhen added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. dependencies and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Jun 20, 2018
@yihanzhen yihanzhen self-assigned this Jun 27, 2018
@sduskis sduskis removed the priority: p2 Moderately-important priority. Fix may not be included in next release. label Oct 9, 2018
@chingor13 chingor13 added the type: docs Improvement to the documentation for an API. label Oct 9, 2018
@chingor13
Copy link
Contributor

This was fixed in #3269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
dependencies type: docs Improvement to the documentation for an API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@chingor13 @sduskis @JustinBeckwith @patflynn @yihanzhen