Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to latest grpc #3373

Closed
garrettjonesgoogle opened this issue Jun 13, 2018 · 2 comments
Closed

Upgrade to latest grpc #3373

garrettjonesgoogle opened this issue Jun 13, 2018 · 2 comments
Assignees
@yihanzhen
Labels
dependencies grpc priority: p2 Moderately-important priority. Fix may not be included in next release.

Comments

@garrettjonesgoogle
Copy link
Member

We currently depend on 1.10.1, but 1.12.0 is available now.
@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Jun 13, 2018
@yihanzhen yihanzhen added priority: p2 Moderately-important priority. Fix may not be included in next release. grpc and removed triage me I really want to be triaged. labels Jun 13, 2018
@yihanzhen
Copy link
Contributor

@garrettjonesgoogle Can I just bump it manually or should this be done by codegen?

@garrettjonesgoogle
Copy link
Member Author

Bump it manually, and run integration tests locally to make sure they pass (since CI doesn't run integration tests on PRs)

@yihanzhen yihanzhen mentioned this issue Jun 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yihanzhen yihanzhen

Labels
dependencies grpc priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JustinBeckwith @garrettjonesgoogle @yihanzhen