Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pub/Sub: ApiFutures.addCallback() deprecated in code example #3920

Closed
anguillanneuf opened this issue Nov 7, 2018 · 0 comments · Fixed by #6100
Closed

Pub/Sub: ApiFutures.addCallback() deprecated in code example #3920

anguillanneuf opened this issue Nov 7, 2018 · 0 comments · Fixed by #6100
Assignees
@chingor13
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@anguillanneuf
Copy link
Contributor

google-cloud-java/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java

Line 177 in 7e63569

* ApiFutures.addCallback(messageIdFuture, new ApiFutureCallback<String>() {

I updated this method in google-cloud-examples, but it also needs to be updated in google-cloud-client/google-cloud-pubsub.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: update Pub/Sub publisher docstring example googleapis/google-cloud-java
4 participants
@chingor13 @JustinBeckwith @anguillanneuf @JesseLovelace