Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gke-connect-gateway is missing generated sample Java files #8564

Closed
suztomo opened this issue Oct 10, 2022 · 0 comments · Fixed by #8569
Closed

gke-connect-gateway is missing generated sample Java files #8564

suztomo opened this issue Oct 10, 2022 · 0 comments · Fixed by #8569
Assignees
@suztomo
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@suztomo
Copy link
Member

suztomo commented Oct 10, 2022 •
edited
Loading

https://github.com/googleapis/google-cloud-java/pull/8448/files#diff-6f4bf033e81fa8aff765a5b95e68c67e018e01507552708e0ad52f0d4584e111

Screen Shot 2022-10-10 at 3 37 56 PM

https://github.com/googleapis/googleapis-gen/tree/master/google/cloud/gkeconnect/gateway/v1beta1/google-cloud-gkeconnect-gateway-v1beta1-java/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1

Steps:

suztomo@suztomo:/tmp$ git clone https://github.com/googleapis/google-cloud-java
suztomo@suztomo:/tmp$ git clone https://github.com/googleapis/googleapis-gen
suztomo@suztomo:/tmp$ cd google-cloud-java
suztomo@suztomo:/tmp/google-cloud-java$ module=java-gke-connect-gateway
suztomo@suztomo:/tmp/google-cloud-java$ GOOGLEAPIS_DIR=/tmp/googleapis-gen
suztomo@suztomo:/tmp/google-cloud-java$  docker run --rm --user "$(id -u):$(id -g)" \
        -v "$(pwd):/repo" \
        -v "${GOOGLEAPIS_DIR}:/googleapis-gen" \
        -w /repo \
        --env HOME=/tmp \
        gcr.io/cloud-devrel-public-resources/owlbot-cli:latest copy-code \
        --source-repo=/googleapis-gen \
        --config-file=${module}/.OwlBot.yaml

The command above creates:

suztomo@suztomo:/tmp/google-cloud-java$ find owl-bot-staging/java-gke-connect-gateway/v1beta1/samples/snippets/generated -name '*.java'
owl-bot-staging/java-gke-connect-gateway/v1beta1/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayserviceclient/patchresource/AsyncPatchResource.java
owl-bot-staging/java-gke-connect-gateway/v1beta1/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayserviceclient/patchresource/SyncPatchResource.java
owl-bot-staging/java-gke-connect-gateway/v1beta1/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayserviceclient/putresource/SyncPutResource.java
owl-bot-staging/java-gke-connect-gateway/v1beta1/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayserviceclient/putresource/AsyncPutResource.java
owl-bot-staging/java-gke-connect-gateway/v1beta1/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayserviceclient/postresource/SyncPostResource.java
owl-bot-staging/java-gke-connect-gateway/v1beta1/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayserviceclient/postresource/AsyncPostResource.java
owl-bot-staging/java-gke-connect-gateway/v1beta1/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayserviceclient/getresource/AsyncGetResource.java
owl-bot-staging/java-gke-connect-gateway/v1beta1/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayserviceclient/getresource/SyncGetResource.java
owl-bot-staging/java-gke-connect-gateway/v1beta1/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayserviceclient/deleteresource/SyncDeleteResource.java
owl-bot-staging/java-gke-connect-gateway/v1beta1/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayserviceclient/deleteresource/AsyncDeleteResource.java
owl-bot-staging/java-gke-connect-gateway/v1beta1/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayserviceclient/create/SyncCreateSetEndpoint.java
owl-bot-staging/java-gke-connect-gateway/v1beta1/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayserviceclient/create/SyncCreateSetCredentialsProvider.java
owl-bot-staging/java-gke-connect-gateway/v1beta1/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayservicesettings/getresource/SyncGetResource.java
owl-bot-staging/java-gke-connect-gateway/v1beta1/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/stub/gatewayservicestubsettings/getresource/SyncGetResource.java

docker run --rm --user "$(id -u):$(id -g)" \
        -v "$(pwd):/workspace"   -w /workspace \
        --env HOME=/tmp \
        gcr.io/cloud-devrel-public-resources/owlbot-java

The files are there:

suztomo@suztomo:/tmp/google-cloud-java$ find java-gke-connect-gateway/samples/snippets/generated -name '*.java'
java-gke-connect-gateway/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayserviceclient/patchresource/AsyncPatchResource.java
java-gke-connect-gateway/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayserviceclient/patchresource/SyncPatchResource.java
java-gke-connect-gateway/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayserviceclient/putresource/SyncPutResource.java
java-gke-connect-gateway/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayserviceclient/putresource/AsyncPutResource.java
java-gke-connect-gateway/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayserviceclient/postresource/SyncPostResource.java
java-gke-connect-gateway/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayserviceclient/postresource/AsyncPostResource.java
java-gke-connect-gateway/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayserviceclient/getresource/AsyncGetResource.java
java-gke-connect-gateway/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayserviceclient/getresource/SyncGetResource.java
java-gke-connect-gateway/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayserviceclient/deleteresource/SyncDeleteResource.java
java-gke-connect-gateway/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayserviceclient/deleteresource/AsyncDeleteResource.java
java-gke-connect-gateway/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayserviceclient/create/SyncCreateSetEndpoint.java
java-gke-connect-gateway/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayserviceclient/create/SyncCreateSetCredentialsProvider.java
java-gke-connect-gateway/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/gatewayservicesettings/getresource/SyncGetResource.java
java-gke-connect-gateway/samples/snippets/generated/com/google/cloud/gkeconnect/gateway/v1beta1/stub/gatewayservicestubsettings/getresource/SyncGetResource.java
@suztomo suztomo added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 10, 2022
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 10, 2022
@suztomo suztomo self-assigned this Oct 10, 2022
@lqiu96 lqiu96 mentioned this issue Oct 10, 2022
Closed
@suztomo suztomo mentioned this issue Oct 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suztomo suztomo

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: regenerating java-gke-connect-gateway generated samples suztomo/google-cloud-java
1 participant
@suztomo