Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is release-trigger configured correctly? #8613

Closed
suztomo opened this issue Oct 14, 2022 · 4 comments · Fixed by #8615
Closed

Is release-trigger configured correctly? #8613

suztomo opened this issue Oct 14, 2022 · 4 comments · Fixed by #8615
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@suztomo
Copy link
Member

suztomo commented Oct 14, 2022 •
edited
Loading

Merging #8610 didn't trigger the job. We manually triggered the job via fusion. This was the first release from this repository. Is release-trigger configured correctly in this repository?
@suztomo suztomo added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 14, 2022
@chingor13
Copy link
Contributor

It's configured to not tag any releases:

google-cloud-java/release-please-config.json

Line 3 in 0db282c

"skip-github-release": true,

@chingor13 chingor13 mentioned this issue Oct 14, 2022
Merged
@meltsufin
Copy link
Member

Is tagging releases the same as triggering the release job?

@suztomo
Copy link
Member Author

suztomo commented Oct 17, 2022 •
edited
Loading

It still doesn't trigger the job

#8623

The repository seems to have the correct GitHub Apps.

Screen Shot 2022-10-17 at 2 14 03 PM

@suztomo suztomo reopened this Oct 17, 2022
@suztomo
Copy link
Member Author

suztomo commented Oct 18, 2022

#8626 fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: have release-please tag releases googleapis/google-cloud-java
3 participants
@suztomo @chingor13 @meltsufin