Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [gameservices] Remove the gameservices APIs #9787

Merged
merged 5 commits into from
Sep 11, 2023
Merged

feat: [gameservices] Remove the gameservices APIs #9787

merged 5 commits into from
Sep 11, 2023

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Aug 29, 2023

  • Regenerate this pull request now.

PiperOrigin-RevId: 561043692

Source-Link: googleapis/googleapis@78b257e

Source-Link: https://github.com/googleapis/googleapis-gen/commit/99e007f6c074261d57f9f38e26d55632c9061fa9
Copy-Tag: eyJwIjoiamF2YS1nYW1lLXNlcnZlcnMvLk93bEJvdC55YW1sIiwiaCI6Ijk5ZTAwN2Y2YzA3NDI2MWQ1N2Y5ZjM4ZTI2ZDU1NjMyYzkwNjFmYTkifQ==

@gcf-owl-bot
feat: Remove the gameservices APIs
a8a266c 
PiperOrigin-RevId: 561043692

Source-Link: googleapis/googleapis@78b257e

Source-Link: https://github.com/googleapis/googleapis-gen/commit/99e007f6c074261d57f9f38e26d55632c9061fa9
Copy-Tag: eyJwIjoiamF2YS1nYW1lLXNlcnZlcnMvLk93bEJvdC55YW1sIiwiaCI6Ijk5ZTAwN2Y2YzA3NDI2MWQ1N2Y5ZjM4ZTI2ZDU1NjMyYzkwNjFmYTkifQ==
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 29, 2023
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review August 29, 2023 18:28
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 29, 2023
@snippet-bot
Copy link

snippet-bot bot commented Aug 29, 2023

Here is the summary of changes.

You are about to delete 256 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 29, 2023
@alicejli alicejli added the automerge Merge the pull request once unit tests and other checks pass. label Aug 30, 2023
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 31, 2023
@mpeddada1
Copy link
Contributor

mpeddada1 commented Sep 8, 2023 •
edited
Loading

The ITSystemTest file for this service hasn't been reemoved.

19:10:32:317 [ERROR]   symbol:   class GetGameServerConfigRequest
19:10:32:317 [ERROR]   location: class com.google.cloud.gaming.v1.it.ITSystemTest
19:10:32:317 [ERROR] /tmpfs/src/github/google-cloud-java/java-game-servers/google-cloud-game-servers/src/test/java/com/google/cloud/gaming/v1/it/ITSystemTest.java:[254,9] cannot find symbol
19:10:32:317 [ERROR]   symbol:   variable GetGameServerConfigRequest
19:10:32:317 [ERROR]   location: class com.google.cloud.gaming.v1.it.ITSystemTest
19:10:32:317 [ERROR] /tmpfs/src/github/google-cloud-java/java-game-servers/google-cloud-game-servers/src/test/java/com/google/cloud/gaming/v1/it/ITSystemTest.java:[255,5] cannot find symbol
19:10:32:318 [ERROR]   symbol:   class GameServerConfig
19:10:32:318 [ERROR]   location: class com.google.cloud.gaming.v1.it.ITSystemTest
19:10:32:318 [ERROR] /tmpfs/src/github/google-cloud-java/java-game-servers/google-cloud-game-servers/src/test/java/com/google/cloud/gaming/v1/it/ITSystemTest.java:[264,5] cannot find symbol
19:10:32:318 [ERROR]   symbol:   class ListGameServerConfigsRequest
19:10:32:318 [ERROR]   location: class com.google.cloud.gaming.v1.it.ITSystemTest
19:10:32:318 [ERROR] /tmpfs/src/github/google-cloud-java/java-game-servers/google-cloud-game-servers/src/test/java/com/google/cloud/gaming/v1/it/ITSystemTest.java:[265,9] cannot find symbol
19:10:32:318 [ERROR]   symbol:   variable ListGameServerConfigsRequest
19:10:32:318 [ERROR]   location: class com.google.cloud.gaming.v1.it.ITSystemTest
19:10:32:319 [ERROR] /tmpfs/src/github/google-cloud-java/java-game-servers/google-cloud-game-servers/src/test/java/com/google/cloud/gaming/v1/it/ITSystemTest.java:[268,10] cannot find symbol
19:10:32:319 [ERROR]   symbol:   class GameServerConfig
19:10:32:319 [ERROR]   location: class com.google.cloud.gaming.v1.it.ITSystemTest
19:10:32:319 [ERROR] /tmpfs/src/github/google-cloud-java/java-game-servers/google-cloud-game-servers/src/test/java/com/google/cloud/gaming/v1/it/ITSystemTest.java:[271,10] cannot find symbol
19:10:32:319 [ERROR]   symbol:   class GameServerConfig
19:10:32:319 [ERROR]   location: class com.google.cloud.gaming.v1.it.ITSystemTest

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 9, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 9, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 10, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 10, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 10, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 11, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 11, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 11, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 11, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 11, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 11, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 11, 2023
@mpeddada1
Copy link
Contributor

mpeddada1 commented Sep 11, 2023 •
edited
Loading

The original PR only deleted the .java classes but still kept the pom.xml files and the java-game-servers module. Created a manual commit to:

  • Delete the java-game-servers module.
  • Remove com.google.cloud:google-cloud-game-servers-bom from the <dependencies> block in gapic-libraries-bom/pom.xml.

@mpeddada1 mpeddada1 added the automerge Merge the pull request once unit tests and other checks pass. label Sep 11, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 4a8106d into main Sep 11, 2023
28 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the owl-bot-copy-java-game-servers branch September 11, 2023 15:58
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 11, 2023
@release-please release-please bot mentioned this pull request Sep 11, 2023
Merged
@mpeddada1 mpeddada1 mentioned this pull request Sep 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alicejli alicejli alicejli approved these changes

@suztomo suztomo suztomo approved these changes

Assignees
No one assigned
Labels
owl-bot-copy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mpeddada1 @suztomo @alicejli @yoshi-kokoro