Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Remove gax-grpc from Compute #9864

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

blakeli0
Copy link
Contributor

Remove gax-grpc from Compute as ProtobufMessageFeature is removed from gax-grpc, and static reflect-config.json are now generated. See googleapis/sdk-platform-java#1323 for details.

Remove gax-grpc from Compute as ProtobufMessageFeature is removed from gax-grpc, and static reflect-config.json are now generated.
Copy link
Contributor

@mpeddada1 mpeddada1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @blakeli0! This is a great catch

@blakeli0 blakeli0 added kokoro:run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Sep 22, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 22, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit e094b31 into main Sep 22, 2023
26 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the blakeli0-patch-1 branch September 22, 2023 23:02
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants