Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maxRetries not passed through to GrpcService #1357

Closed
stephenplusplus opened this issue Jun 3, 2016 · 1 comment
Closed

maxRetries not passed through to GrpcService #1357

stephenplusplus opened this issue Jun 3, 2016 · 1 comment
Assignees
@stephenplusplus
Labels
api: pubsub Issues related to the Pub/Sub API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@stephenplusplus
Copy link
Contributor

stephenplusplus commented Jun 3, 2016 •
edited
Loading

Caught here: #1356 (comment)
@stephenplusplus stephenplusplus added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: pubsub Issues related to the Pub/Sub API. labels Jun 3, 2016
@stephenplusplus stephenplusplus self-assigned this Jun 3, 2016
@stephenplusplus
Copy link
Contributor Author

Also, it needs to be renamed to retries -- retry-request expects retries, not maxRetries.

This was referenced Jun 3, 2016
Closed
Merged
@richardkazuomiller richardkazuomiller mentioned this issue Aug 30, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephenplusplus stephenplusplus

Labels
api: pubsub Issues related to the Pub/Sub API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stephenplusplus