Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1990 seems to be breaking File.save #2078

Closed
q42jaap opened this issue Mar 14, 2017 · 1 comment
Closed

#1990 seems to be breaking File.save #2078

q42jaap opened this issue Mar 14, 2017 · 1 comment
Assignees
Labels
api: storage Issues related to the Cloud Storage API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@q42jaap
Copy link

q42jaap commented Mar 14, 2017

#1990 is breaking my code:
I'm getting an error which is suppressed by makeAuthenticatedRequest.
The error which is suppressed: value.hasOwnProperty is not a function which is triggered on the line:
https://github.com/GoogleCloudPlatform/google-cloud-node/pull/1990/files#diff-4ddf84f5cae46867fbddaf62136f04c3R521

The object value is looks something like this
screen shot 2017-03-14 at 01 53 46

Reverting to 0.47.0 fixes this for me.

I'm doing a File.save (from the storage module).

The config for storage is {projectId: '...'}. I'm using the credentials provided by de gcloud sdk.

@stephenplusplus
Copy link
Contributor

This is fixed in @google-cloud/storage (dupe #2070), but a new version of google-cloud hasn't been released yet. We'll be doing that tomorrow, but if you need a solution in the meantime, you can use @google-cloud/storage directly. Sorry for the trouble and thank you for reporting.

@stephenplusplus stephenplusplus added api: storage Issues related to the Cloud Storage API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants