Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.mocharc.js and .prettierrc.js are tracked for code coverage #2996

Open
JustinBeckwith opened this issue Apr 17, 2020 · 3 comments
Open

.mocharc.js and .prettierrc.js are tracked for code coverage #2996

JustinBeckwith opened this issue Apr 17, 2020 · 3 comments
Assignees
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@JustinBeckwith
Copy link
Contributor

Since moving to *.js files for both of these, they're suddenly getting picked up by c8 and bringing our code coverage numbers down :) Would be lovely to ship an updated c8 config!

@JustinBeckwith JustinBeckwith added the type: process A process-related concern. May include testing, release, or the like. label Apr 17, 2020
@bcoe
Copy link
Contributor

bcoe commented Apr 17, 2020

@JustinBeckwith before we ship an updated c8 config, I think there's a strong argument for this to just be ignored by default in c8's ignore rules.

@bcoe
Copy link
Contributor

bcoe commented Apr 17, 2020

see: istanbuljs/schema#14 ... but, refreshing myself with our approach we actually still need to add these value to our own config.

@danielbankhead
Copy link
Contributor

Idea: we can remove these files altogether if we want by moving the config to package.json (bonus: makes the base directory smaller):

Ex: https://github.com/danielbankhead/picture-playlist/blob/main/package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

3 participants