Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip publishing samples directories #3332

Closed
chingor13 opened this issue Sep 8, 2022 · 1 comment · Fixed by #3333
Closed

skip publishing samples directories #3332

chingor13 opened this issue Sep 8, 2022 · 1 comment · Fixed by #3333
Assignees
@chingor13
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@chingor13
Copy link
Contributor

This causes release jobs to fail. Example: #3318
@chingor13 chingor13 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Sep 8, 2022
@chingor13 chingor13 self-assigned this Sep 8, 2022
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 8, 2022
@chingor13 chingor13 changed the title samples package.json fileds need dummy publish script skip publishing samples directories Sep 8, 2022
@chingor13
Copy link
Contributor Author

Apparently, setting a publish script in package.json is not enough to skip the publish step.

This was referenced Sep 8, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: exclude samples directories from publishing googleapis/google-cloud-node
1 participant
@chingor13