Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The region tags used in the samples should be aiplatformnotebooks #1678

Closed
ahrarmonsur opened this issue Nov 9, 2022 · 1 comment
Closed

The region tags used in the samples should be aiplatformnotebooks #1678

ahrarmonsur opened this issue Nov 9, 2022 · 1 comment
Assignees
@balajismaniam
Labels
api: notebooks Issues related to the Vertex AI Workbench API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.

Comments

@ahrarmonsur
Copy link

ahrarmonsur commented Nov 9, 2022 •
edited by iennae
Loading

  1. Is this a client library issue or a product issue?
    Client library issue with samples.

  2. Did someone already solve this?
    no

  3. Do you have a support contract?
    No - Internal request

Issue:
The region tags used in the samples (generated and handwritten) are using the invalid product prefix notebooks.
There are 67 region tags that need to be updated based on this search https://github.com/search?q=repo%3Agoogleapis%2Fgoogle-cloud-node+%5BSTART+notebooks&type=code&p=4

The impact of this is that these samples don't show up correctly in devrelservices and so wouldn't get included in Sample Browser.

Resolution:
The region tags should have their product prefix updated to aiplatformnotebooks, the correct prefix for Vertex AI Workbench.
@ahrarmonsur ahrarmonsur added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Nov 9, 2022
@product-auto-label product-auto-label bot added api: notebooks Issues related to the Vertex AI Workbench API. samples Issues that are directly related to samples. labels Nov 9, 2022
@balajismaniam balajismaniam self-assigned this Nov 11, 2022
@sofisl sofisl transferred this issue from googleapis/nodejs-notebooks Dec 21, 2022
@iennae iennae added type: cleanup An internal cleanup or hygiene concern. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 5, 2023
@sofisl sofisl transferred this issue from googleapis/google-cloud-node Feb 3, 2025
@sofisl
Copy link
Contributor

sofisl commented Feb 3, 2025

Actually, this seems to no longer be an issue: https://github.com/googleapis/google-cloud-node/blob/8940a6e72a9a4117cac8f0aba6f0e0cb4d885677/packages/google-cloud-aiplatform/samples/generated/v1/dataset_service.create_dataset_version.js#L24

@sofisl sofisl closed this as completed Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@balajismaniam balajismaniam

Labels
api: notebooks Issues related to the Vertex AI Workbench API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@iennae @ahrarmonsur @balajismaniam @sofisl