Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impersonated of ProjectsClient is not assignable to authClient type #1934

Closed
7 tasks done
yugo-ibuki opened this issue Aug 21, 2024 · 5 comments
Closed
7 tasks done

Comments

@yugo-ibuki
Copy link

Please make sure you have searched for information in the following guides.

A screenshot that you have tested with "Try this API".

this is the package error, so there is no screenshot about "Try this API".

Link to the code that reproduces this issue. A link to a public Github Repository or gist with a minimal reproduction.

https://github.com/yugo-ibuki/auth-type-error

A step-by-step description of how to reproduce the issue, based on the linked reproduction.

Impersonated function from google-auth-library is not assignable to JSONClient.
so, type check by tsc fails.

スクリーンショット 2024-08-21 23 25 28

A clear and concise description of what the bug is, and what you expected to happen.

Every time google-auth-library is updated, this error occurs. So, I should update yarn.lock.
I think package version is not latest, but I didn't figure out the detail.

A clear and concise description WHY you expect this behavior, i.e., was it a recent change, there is documentation that points to this behavior, etc. **

Type check should pass, even if I update the package.

Copy link

Issue was opened with an invalid reproduction link. Please make sure the repository is a valid, publicly-accessible github repository, and make sure the url is complete (example: https://github.com/googleapis/google-cloud-node)

@sofisl sofisl reopened this Sep 23, 2024
@sofisl
Copy link
Contributor

sofisl commented Sep 23, 2024

This was closed incorrectly, sorry! Small issue with regex.

Copy link

Issue was opened with an invalid reproduction link. Please make sure the repository is a valid, publicly-accessible github repository, and make sure the url is complete (example: https://github.com/googleapis/google-cloud-node)

@kyong0612
Copy link

@sofisl

This was closed incorrectly, sorry! Small issue with regex.

Is this Issue reopen?

@sofisl sofisl reopened this Sep 30, 2024
@sofisl sofisl transferred this issue from googleapis/google-cloud-node Feb 4, 2025
@d-goog
Copy link
Collaborator

d-goog commented Feb 5, 2025

Every time google-auth-library is updated, this error occurs. So, I should update yarn.lock.
I think package version is not latest, but I didn't figure out the detail.

Thanks for filing @yugo-ibuki, this issue can appear when the packages are not in sync. This is outside of the scope of the client libraries and more-so a package manager issue; if google-auth-library v9 is updated, then the other packages with the same supported major release should be updated as well.

We could make this slightly better by re-exporting google-auth-library from this library, however it wouldn't scale if multiple client libraries are used.

@d-goog d-goog closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants