Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[securitycenter] v2 client's apiEndpoint property is wrong when a regional endpoint is specified #5719

Open
7 tasks done
hegemonic opened this issue Sep 27, 2024 · 2 comments

Comments

@hegemonic
Copy link
Contributor

Please make sure you have searched for information in the following guides.

A screenshot that you have tested with "Try this API".

n/a

Link to the code that reproduces this issue. A link to a public Github Repository or gist with a minimal reproduction.

https://gist.github.com/hegemonic/cf807026d8b83c14aa0b225b16967599

A step-by-step description of how to reproduce the issue, based on the linked reproduction.

Run the code. It creates a v2 SecurityCenterClient; sets the apiEndpoint to securitycenter.me-central2.rep.googleapis.com; and prints the expected and actual apiEndpoint for the client.

A clear and concise description of what the bug is, and what you expected to happen.

The code prints the following:

expected apiEndpoint: securitycenter.me-central2.rep.googleapis.com
actual apiEndpoint: securitycenter.googleapis.com
client._opts.apiEndpoint: securitycenter.me-central2.rep.googleapis.com

I expected it to print the following:

expected apiEndpoint: securitycenter.me-central2.rep.googleapis.com
actual apiEndpoint: securitycenter.me-central2.rep.googleapis.com
client._opts.apiEndpoint: securitycenter.me-central2.rep.googleapis.com

A clear and concise description WHY you expect this behavior, i.e., was it a recent change, there is documentation that points to this behavior, etc. **

  • If I specify an API endpoint, the client object shouldn't say that it's using the default endpoint.
  • You shouldn't need to look at private properties to figure out which endpoint the client is using.
Copy link
Contributor

Issue was opened with an invalid reproduction link. Please make sure the repository is a valid, publicly-accessible github repository, and make sure the url is complete (example: https://github.com/googleapis/google-cloud-node)

@hegemonic
Copy link
Contributor Author

@sofisl Why was this bug closed? I provided a valid link to a publicly visible gist.

@sofisl sofisl reopened this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants