fix: fix NotImplementedError for get_or_insert inside a transaction (#451)

Fixes #433

Author: Chris Rossi

packages/google-cloud-ndb/google/cloud/ndb/_datastore_api.py

@@ -568,7 +568,7 @@ def _get_commit_batch(transaction, options):
     # call would all need to be identical. For now, no options are supported
     # here.
     for key, value in options.items():
-        if value:
+        if key != "transaction" and value:
             raise NotImplementedError("Passed bad option: {!r}".format(key))
 
     # Since we're in a transaction, we need to hang on to the batch until

packages/google-cloud-ndb/tests/system/test_crud.py

@@ -865,18 +865,28 @@ class SomeKind(ndb.Model):
 
 
 @pytest.mark.usefixtures("client_context")
-def test_get_or_insert_get_in_transaction(ds_entity):
+def test_get_or_insert_in_transaction(dispose_of):
+    """Regression test for #433
+
+    https://github.com/googleapis/python-ndb/issues/433
+    """
+
     class SomeKind(ndb.Model):
         foo = ndb.IntegerProperty()
 
     name = "Inigo Montoya"
     assert SomeKind.get_by_id(name) is None
 
-    def do_the_thing():
-        ds_entity(KIND, name, foo=42)
-        return SomeKind.get_or_insert(name, foo=21)
+    @ndb.transactional()
+    def do_the_thing(foo):
+        entity = SomeKind.get_or_insert(name, foo=foo)
+        return entity
+
+    entity = do_the_thing(42)
+    dispose_of(entity._key._key)
+    assert entity.foo == 42
 
-    entity = ndb.transaction(do_the_thing)
+    entity = do_the_thing(21)
     assert entity.foo == 42