Merge pull request #879 from tseaver/825-storage-bucket_cleanup

Really remove 'Bucket._connection' bits.

Author: tseaver

gcloud/storage/bucket.py

@@ -104,9 +104,8 @@ class Bucket(_PropertyMixin):
     _MAX_OBJECTS_FOR_BUCKET_DELETE = 256
     """Maximum number of existing objects allowed in Bucket.delete()."""
 
-    def __init__(self, name=None, connection=None):
+    def __init__(self, name=None):
         super(Bucket, self).__init__(name=name)
-        self._connection = connection
         self._acl = BucketACL(self)
         self._default_object_acl = DefaultObjectACL(self)
 

gcloud/storage/test_bucket.py

@@ -140,7 +140,7 @@ def test___contains___miss(self):
         NAME = 'name'
         NONESUCH = 'nonesuch'
         connection = _Connection()
-        bucket = self._makeOne(NAME, None)
+        bucket = self._makeOne(NAME)
         with _monkey_defaults(connection=connection):
             self.assertFalse(NONESUCH in bucket)
         kw, = connection._requested
@@ -152,7 +152,7 @@ def test___contains___hit(self):
         NAME = 'name'
         BLOB_NAME = 'blob-name'
         connection = _Connection({'name': BLOB_NAME})
-        bucket = self._makeOne(NAME, None)
+        bucket = self._makeOne(NAME)
         with _monkey_defaults(connection=connection):
             self.assertTrue(BLOB_NAME in bucket)
         kw, = connection._requested