Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Storage after #9915, incompatible change. #10009

Closed
crwilcox opened this issue Dec 23, 2019 · 1 comment · Fixed by #10010
Closed

Update Storage after #9915, incompatible change. #10009

crwilcox opened this issue Dec 23, 2019 · 1 comment · Fixed by #10010
Assignees
Labels
api: storage Issues related to the Cloud Storage API. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@crwilcox
Copy link
Contributor

crwilcox commented Dec 23, 2019

Currently unit and system tests for storage are failing due to a change introduced by #9915

headers[CLIENT_INFO_HEADER] = self.user_agent
        headers["User-Agent"] = self.user_agent

        return self._do_request(
>           method, url, headers, data, target_object, timeout=timeout
        )
E       TypeError: _do_request() got an unexpected keyword argument 'timeout'

Unit Tests: 29 failed, 681 passed, 2 skipped in 14.05s

Update minimum versions for core/api core in storage to

    "google-auth >= 1.9.0, < 2.0dev",
    "google-api-core >= 1.15.0, < 2.0dev",
    "google-cloud-core >= 1.1.0, < 2.0dev"

Rerun tests and adjust to account for timeout param.

@crwilcox crwilcox added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: storage Issues related to the Cloud Storage API. labels Dec 23, 2019
@HemangChothani
Copy link
Contributor

Duplicate issue of 9951 and it's PR 9992

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
3 participants