-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GAX API hangs during (second) 'publish' #1869
Comments
To reproduce: $ git clone git@github.com:tseaver/gcloud
$ cd gcloud
$ git checkout 1855-moar_gax_paging_fixes
$ tox -e system-tests --notest
$ PYTHONPATH= .tox/system-tests/bin/python system_tests/run_system_test.py --package=pubsub |
Seems like the PublishResponse object is being returned without Have you gotten the API |
@bjwatson I had an earlier error in my system test masking this problem, so I have never actually seen |
@bjwatson One thing different from the other Pubsub APIs (which are working AFAICS, except |
@bjwatson could it be an issue that the event unpacking code isn't handling repeated elements (e.g., |
@bjwatson To reproduce (updated): $ git clone git@github.com:GoogleCloudPlatform/gcloud
$ cd gcloud
$ tox -e system-tests --notest
$ GCLOUD_ENABLE_GAX=1 PYTHONPATH= .tox/system-tests/bin/python system_tests/run_system_test.py --package=pubsub |
cc @tbetbetbe |
Hi @tseaver. Sorry for the delay; I was looking into a few other things. I'll try what you suggested and let you know what I find. |
I have successfully reproduced this issue on my workstation and am looking into it. |
So what I've discovered so far is that Based on code analysis, I believe this is being thrown by https://github.com/googleapis/gax-python/blob/master/google/gax/bundling.py#L193. I'm not sure why we haven't discovered this before. Is this the first time the The bundling configuration for the
I'm about to sign off for the night. @tbetbetbe Do you have some time to look into this during your morning shift? |
@tseaver This is a bug in gax-python. I created issue googleapis/gax-python#110 to track it, and plan to fix it today. |
@bjwatson Thanks very much! |
@tseaver No problem. I have a fix in code review now: googleapis/gax-python#111 Once this is merged, I will publish new versions of gax-python, pubsub, and logging. And then I will verify that this issue is closed. This should be finished tomorrow. |
@tseaver I have fixed this issue with https://pypi.python.org/pypi/google-gax/0.12.1 and https://pypi.python.org/pypi/gax-google-pubsub-v1/0.7.10. Now the behavior I'm seeing is that the I'm about to wrap up for the day. Can you take a look and see what you think? |
I also updated logging, although I have not yet looked into #1889 |
@tseaver I got caught up in some other things today. Can you or @daspecster look into the indefinite hang on the second call to |
This seems to be a [gax-python](https://github.com/googleapis/gax-python issue). The hang is happening at https://github.com/GoogleCloudPlatform/gcloud-python/blob/master/gcloud/pubsub/_gax.py#L170, but only happens for the second call. I'll look at it some more on Monday, unless @tbetbetbe or @geigerj get to it first. |
|
@geigerj Thanks for the pointer! #1910 disables bundling as you suggest. We can think about re-enabling it after a fix for googleapis/gax-python#113 is released. |
/cc @bjwatson
The text was updated successfully, but these errors were encountered: