Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pubsub API should provide a way to synchronize a set of operations #4913

Closed
gcbirzan opened this issue Feb 22, 2018 · 3 comments · Fixed by #9365
Closed

Pubsub API should provide a way to synchronize a set of operations #4913

gcbirzan opened this issue Feb 22, 2018 · 3 comments · Fixed by #9365
Assignees
@IlyaFaer
Labels
api: pubsub Issues related to the Pub/Sub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@gcbirzan
Copy link
Contributor

The pubsub API provides no easy way to make sure a bunch of publishes finish before continuing. You have to either deal with batches yourself or wait on every Future returned. A context manager would do the job, or even a wait method on the client.
@theacodes theacodes added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: pubsub Issues related to the Pub/Sub API. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 22, 2018
@theacodes
Copy link
Contributor

@lukesneeringer what do you think?

@lukesneeringer
Copy link
Contributor

Seems reasonable to me. asyncio does have a mechanism to wait on multiple futures but that does not help anyone on earlier versions of Python.

@theacodes theacodes mentioned this issue Feb 22, 2018
Closed
@chemelnucfin chemelnucfin self-assigned this Feb 25, 2018
@JustinBeckwith JustinBeckwith added the 🚨 This issue needs some love. label Aug 21, 2018
@tseaver tseaver removed 🚨 This issue needs some love. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Sep 12, 2018
@sduskis
Copy link
Contributor

sduskis commented May 15, 2019

@theacodes, do you think this is still a GA blocking issue?

@IlyaFaer IlyaFaer self-assigned this Sep 28, 2019
@IlyaFaer IlyaFaer mentioned this issue Oct 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IlyaFaer IlyaFaer

Labels
api: pubsub Issues related to the Pub/Sub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(pubsub): add stop method MaxxleLLC/google-cloud-python
8 participants
@lukesneeringer @sduskis @tseaver @theacodes @JustinBeckwith @gcbirzan @chemelnucfin @IlyaFaer