Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updated additional documentation link for field annotations in message .google.rpc.context.AttributeContext #28123

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Dec 18, 2024

  • Regenerate this pull request now.

docs: Clarified that field metadata in google.rpc.ErrorInfo should be lowerCamelCase
feat: Improved support for multiple google.rpc.BadRequest.FieldViolation errors

Added reason and localized_messsage fields to google.rpc.BadRequest.FieldViolation. This allows each violation to have a machine readable identifier and error message that is safe to return to the API consumer.

PiperOrigin-RevId: 707591563

Source-Link: googleapis/googleapis@f4b0261

Source-Link: https://github.com/googleapis/googleapis-gen/commit/b26110f1dc3f4a99c4ca29fd010f3f2f043e4a6d
Copy-Tag: eyJwIjoiZ29vZ2xlLWNsb3VkLXZtX21pZ3JhdGlvbi12MS8uT3dsQm90LnlhbWwiLCJoIjoiYjI2MTEwZjFkYzNmNGE5OWM0Y2EyOWZkMDEwZjNmMmYwNDNlNGE2ZCJ9

…n message `.google.rpc.context.AttributeContext`

docs: Clarified that field `metadata` in `google.rpc.ErrorInfo` should be lowerCamelCase
feat: Improved support for multiple `google.rpc.BadRequest.FieldViolation` errors

Added `reason` and `localized_messsage` fields to `google.rpc.BadRequest.FieldViolation`. This allows each violation to have a machine readable identifier and error message that is safe to return to the API consumer.

PiperOrigin-RevId: 707591563

Source-Link: googleapis/googleapis@f4b0261

Source-Link: googleapis/googleapis-gen@b26110f
Copy-Tag: eyJwIjoiZ29vZ2xlLWNsb3VkLXZtX21pZ3JhdGlvbi12MS8uT3dsQm90LnlhbWwiLCJoIjoiYjI2MTEwZjFkYzNmNGE5OWM0Y2EyOWZkMDEwZjNmMmYwNDNlNGE2ZCJ9
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 18, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 18, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 18, 2024
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review December 18, 2024 19:57
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 18, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 18, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 18, 2024
Copy link
Member

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feat(vm_migration-v1): Support reason and localized message strings on FieldViolation

@dazuma dazuma merged commit 5257fcd into main Dec 19, 2024
13 checks passed
@dazuma dazuma deleted the owl-bot-copy-google-cloud-vm_migration-v1 branch December 19, 2024 00:13
aandreassa pushed a commit that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants