Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OwlBot reverts the lint fix #871

Open
suztomo opened this issue Apr 12, 2022 · 1 comment
Open

OwlBot reverts the lint fix #871

suztomo opened this issue Apr 12, 2022 · 1 comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release.

Comments

@suztomo
Copy link
Member

suztomo commented Apr 12, 2022 •
edited
Loading

OwlBot reverted the lint fix (#863) in the commit below (right after I merged 863), and now lint is failing in main (So this PR 861 is irrelevant to the lint failure). The lint is not a required check.

b2b2e43

Probably the discrepancy in the google-java-format versions between OwlBot's and this repository's.

CC: @TimurSadykov @Neenu1995
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Apr 13, 2022
@TimurSadykov TimurSadykov added the priority: p3 Desirable enhancement or fix. May not be included in next release. label Apr 14, 2022
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Apr 14, 2022
@suztomo
Copy link
Member Author

suztomo commented Jul 18, 2022

OwlBot uses google-java-format 1.7 (a bit old)
https://github.com/googleapis/synthtool/blob/master/docker/owlbot/java/Dockerfile#L18

@lqiu96 lqiu96 mentioned this issue Jul 18, 2022
Merged
1 task
@TimurSadykov TimurSadykov mentioned this issue Aug 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@suztomo @TimurSadykov @yoshi-automation