Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthorizationCodeResponseUrl doesn't support semicolon as separator #89

Open
wonderfly opened this issue Jan 9, 2015 · 1 comment
Open
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@wonderfly
Copy link
Contributor

wonderfly commented Jan 9, 2015

From ykph...@gmail.com on February 06, 2014 18:48:21

Version of google-oauth-java-client (e.g. 1.5.0-beta)?
1.15.0-rc

Java environment (e.g. Java 6, Android 2.3, App Engine)?
Android 4.1

Describe the problem.
When the redirectUrl is returned in the following format:
http://url?code=abc;state=xyz
AuthorizationCodeResponseUrl doesn't parse it properly, as it only accepts & as the separator.

As per: http://www.w3.org/TR/1999/REC-html401-19991224/appendix/notes.html#h-B.2.2 Semicolon should also be accepted as the separator for the parameters. How would you expect it to be fixed? It should parse the code and state properly when semicolon is used as a separator.

Original issue: http://code.google.com/p/google-oauth-java-client/issues/detail?id=89

@wonderfly wonderfly added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. imported priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jan 9, 2015
@wonderfly wonderfly self-assigned this Jan 9, 2015
@wonderfly wonderfly removed their assignment May 20, 2016
@mattwhisenhunt mattwhisenhunt removed the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Jan 8, 2018
@JustinBeckwith JustinBeckwith added priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. and removed 2–5 stars labels Jun 8, 2018
@chingor13
Copy link
Contributor

Although technically acceptable, Google APIs in general do not allow ; as query parameter. Changing this to a feature request.

@chingor13 chingor13 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jul 17, 2018
@JustinBeckwith JustinBeckwith removed the 🚨 This issue needs some love. label Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants