-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for DecimalTargetTypes #1345
Merged
stephaniewang526
merged 5 commits into
googleapis:master
from
stephaniewang526:decimalTarget
Jun 8, 2021
Merged
feat: add support for DecimalTargetTypes #1345
stephaniewang526
merged 5 commits into
googleapis:master
from
stephaniewang526:decimalTarget
Jun 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Towards b/188414733 Implemented in LoadJobConfiguration
product-auto-label
bot
added
the
api: bigquery
Issues related to the googleapis/java-bigquery API.
label
Jun 2, 2021
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Jun 2, 2021
stephaniewang526
changed the title
feat: add support for DecimalTargetType
feat: add support for DecimalTargetTypes
Jun 7, 2021
MingyuZhong
reviewed
Jun 7, 2021
MingyuZhong
approved these changes
Jun 7, 2021
shollyman
approved these changes
Jun 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I like the exercise of the precision/scale validation in the integration test.
stephaniewang526
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Jun 8, 2021
Will not merge until the UI change reaches golden. |
stephaniewang526
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Jun 8, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 8, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.133.0](https://www.github.com/googleapis/java-bigquery/compare/v1.132.1...v1.133.0) (2021-06-08) ### Features * add support for DecimalTargetTypes ([#1345](https://www.github.com/googleapis/java-bigquery/issues/1345)) ([ba528df](https://www.github.com/googleapis/java-bigquery/commit/ba528df03def71907e2811cf267718f090605d95)) ### Dependencies * update dependency com.google.cloud:google-cloud-bigtable to v1.26.1 ([#1360](https://www.github.com/googleapis/java-bigquery/issues/1360)) ([bf55699](https://www.github.com/googleapis/java-bigquery/commit/bf55699d849de7e873577de04e44fbfe0f078ab1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigquery
Issues related to the googleapis/java-bigquery API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards b/188414733
Implemented in LoadJobConfiguration and ExternalTableDefinition
cc @MingyuZhong