Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JPMS support to google-cloud-bigquery (and other Google Cloud libraries) #3253

Open
Sam-Bate-ITV opened this issue Apr 19, 2024 · 1 comment
Open

Add JPMS support to google-cloud-bigquery (and other Google Cloud libraries) #3253

Sam-Bate-ITV opened this issue Apr 19, 2024 · 1 comment
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. next major: breaking change this is a change that we should wait to bundle into the next major version priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@Sam-Bate-ITV
Copy link

Please add support for JPMS by adding module-info.java file to (google-cloud-bigquery/src/main/java/module-info.java).

This will depend on the com.google.cloud:* dependencies having been modularised first.

It will enable users to use jlink with projects that depend on bigquery
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label Apr 19, 2024
@Sam-Bate-ITV Sam-Bate-ITV mentioned this issue Apr 19, 2024
Open
@PhongChuong PhongChuong added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. next major: breaking change this is a change that we should wait to bundle into the next major version labels Apr 23, 2024
@PhongChuong
Copy link
Contributor

This issue largely depends on sdk-platform-java also implementing the change.
This will be updated if there are any plans to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. next major: breaking change this is a change that we should wait to bundle into the next major version priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PhongChuong @Sam-Bate-ITV