Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add MetadataCacheMode to ExternalTableDefinition #3351

Merged
merged 3 commits into from
Jun 19, 2024
Merged

feat: add MetadataCacheMode to ExternalTableDefinition #3351

merged 3 commits into from
Jun 19, 2024

Conversation

PhongChuong
Copy link
Contributor

@PhongChuong PhongChuong commented Jun 14, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #3350 ☕️

@PhongChuong PhongChuong added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 14, 2024
@PhongChuong PhongChuong marked this pull request as ready for review June 14, 2024 16:52
@PhongChuong PhongChuong requested a review from a team as a code owner June 14, 2024 16:52
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label Jun 15, 2024
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jun 18, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 18, 2024
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner June 18, 2024 19:38
PhongChuong
PhongChuong commented Jun 18, 2024
View reviewed changes
Copy link
Contributor Author

@PhongChuong PhongChuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. Updated. PTAL.

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ExternalTableDefinition.java Show resolved Hide resolved
@PhongChuong PhongChuong merged commit 2814dc4 into main Jun 19, 2024
20 checks passed
@PhongChuong PhongChuong deleted the b346589409 branch June 19, 2024 13:30
@release-please release-please bot mentioned this pull request Jun 22, 2024
Merged
This was referenced Jul 2, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@alvarowolfx alvarowolfx Awaiting requested review from alvarowolfx alvarowolfx is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support MetadataCacheMode in ExternalTableDefinition
3 participants
@PhongChuong @shollyman @yoshi-kokoro