-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ability to specify RetryOptions and BigQueryRetryConfig when create job and waitFor #3398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, just a question about this new configurability in the face of non-query jobs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarifications, looks good!
Thanks for the review. |
…n create job and waitFor (#3398) * feat: initial implementation of customizable BigQueryRetryConfig * Add unit and integration tests * Fix lint issues * Revert unintentional changes to testQueryStatistics in ITBigQueryTest * Revert unintentional changes to testQueryStatistics in ITBigQueryTest * Revert unintentional changes to testQueryStatistics in ITBigQueryTest * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Add additional comments to Job.waitFor() for BigQueryRetryConfig --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Add ability to specify RetryOptions and BigQueryRetryConfig when creating jobs. The RetryOptions and BigQueryRetryConfig are embedded in JobOptions so the BigQuery API interface does not change. This can be extended to other options such as DatasetListOption, DatasetOption, etc. Those options will be added in a future PR as needed.
In addition:
This PR also overloads the job.waitFor() method to allow users to specify BigQueryRetryConfig.
This PR also has a minor refactor to JobTest.java.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #3399 ☕️