Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shutdown stream connection when timeout exception occurs #2445

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

agrawal-siddharth
Copy link
Contributor

Since the timeout exception results in the ConnectionWorker's appendLoop terminating, we must perform all shutdown steps that are performed there.

@agrawal-siddharth agrawal-siddharth requested a review from a team as a code owner March 9, 2024 03:22
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Mar 9, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Mar 9, 2024
@agrawal-siddharth agrawal-siddharth force-pushed the useCommonCleanup branch 3 times, most recently from d62a1d3 to a96affe Compare March 9, 2024 15:01
@agrawal-siddharth agrawal-siddharth added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 12, 2024
@yirutang yirutang merged commit 6e267fb into googleapis:main Mar 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants