Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add version id to the client lib header #2447

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

yirutang
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@yirutang yirutang requested a review from a team as a code owner March 12, 2024 22:57
@yirutang yirutang requested a review from Neenu1995 March 12, 2024 22:57
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Mar 12, 2024
Copy link

conventional-commit-lint-gcf bot commented Mar 12, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Mar 12, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 12, 2024
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 12, 2024
@yirutang yirutang added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 12, 2024
Copy link
Contributor

@agrawal-siddharth agrawal-siddharth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you show what a sample traceId with the library version included looks like?

@yirutang
Copy link
Contributor Author

Can you show what a sample traceId with the library version included looks like?

it should be like "java-streamwriter:3.0.1 user:trace" Same format as the managed go client lib.

Can you show what a sample traceId with the library version included looks like?

@yirutang yirutang merged commit 43fd699 into googleapis:main Mar 12, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. kokoro:run Add this label to force Kokoro to re-run the tests. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants