Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix javadoc errors #1126

Merged
merged 6 commits into from
Jun 29, 2023
Merged

docs: fix javadoc errors #1126

merged 6 commits into from
Jun 29, 2023

Conversation

kolea2
Copy link
Contributor

@kolea2 kolea2 commented Jun 28, 2023

No description provided.

@kolea2 kolea2 requested review from a team as code owners June 28, 2023 17:33
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: datastore Issues related to the googleapis/java-datastore API. labels Jun 28, 2023
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner June 28, 2023 17:36
@suztomo
Copy link
Member

suztomo commented Jun 28, 2023

Among many warnings, there are certain errors.

Error:  /home/runner/work/java-datastore/java-datastore/google-cloud-datastore/src/main/java/com/google/cloud/datastore/StructuredQuery.java:49: error: heading used out of sequence: <H3>, compared to implicit preceding heading: <H1>
Error:   * <h3>A usage example:</h3>
Error:     ^
Error:  /home/runner/work/java-datastore/java-datastore/google-cloud-datastore/src/main/java/com/google/cloud/datastore/GqlQuery.java:44: error: heading used out of sequence: <H3>, compared to implicit preceding heading: <H1>
Error:   * <h3>A usage example:</h3>
Error:     ^

@suztomo
Copy link
Member

suztomo commented Jun 28, 2023

I'm not sure the warnings fail the build or not.

@kolea2
Copy link
Contributor Author

kolea2 commented Jun 28, 2023

Thanks @suztomo, these should be resolved now!

@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2023
suztomo
suztomo approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@kolea2 kolea2 merged commit d4b11bb into googleapis:main Jun 29, 2023
@kolea2 kolea2 deleted the javadoc-fix branch June 29, 2023 15:05
@release-please release-please bot mentioned this pull request Jun 29, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 10, 2023
@release-please
chore(main): release 2.16.1 (#1128)
5ca3bfa 
🤖 I have created a release *beep* *boop*
---


## [2.16.1](https://togithub.com/googleapis/java-datastore/compare/v2.16.0...v2.16.1) (2023-07-10)


### Documentation

* Fix javadoc errors ([#1126](https://togithub.com/googleapis/java-datastore/issues/1126)) ([d4b11bb](https://togithub.com/googleapis/java-datastore/commit/d4b11bbf9198b446365b25617614434865d7e285))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.13.0 ([#1130](https://togithub.com/googleapis/java-datastore/issues/1130)) ([2181847](https://togithub.com/googleapis/java-datastore/commit/2181847666bce403743677b06f90b34e5ae180a3))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
kolea2 added a commit to kolea2/java-datastore that referenced this pull request Jul 28, 2023
@kolea2 @gcf-owl-bot
docs: fix javadoc errors (googleapis#1126)
8c7e0be 
* docs: fix javadoc errors

* fix

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* more fixes

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 28, 2023
@kolea2
docs: fix javadoc errors (#1126) (#1153)
00c68b0 
* docs: fix javadoc errors

* fix

* 🦉 Updates from OwlBot post-processor

See https://togithub.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* more fixes
@release-please release-please bot mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triplequark triplequark triplequark approved these changes

@suztomo suztomo suztomo approved these changes

Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/java-datastore API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kolea2 @suztomo @triplequark