Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update opentelemetry-sdk dependency to be test-only #1595

Merged
merged 3 commits into from
Sep 24, 2024
Merged

fix: Update opentelemetry-sdk dependency to be test-only #1595

merged 3 commits into from
Sep 24, 2024

Conversation

jimit-j-shah
Copy link
Contributor

@jimit-j-shah jimit-j-shah commented Sep 24, 2024 •
edited
Loading

Make opentelemetry-sdk dependency test-only and move RemoteDatastoreHelper to test.

@jimit-j-shah jimit-j-shah requested review from a team as code owners September 24, 2024 07:50
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: datastore Issues related to the googleapis/java-datastore API. labels Sep 24, 2024
@jimit-j-shah
Copy link
Contributor Author

Moved RemoteDatastoreHelper to test as it's used only for testing.

@jimit-j-shah jimit-j-shah merged commit 9d719e8 into main Sep 24, 2024
21 checks passed
@jimit-j-shah jimit-j-shah deleted the jimit/otel-sdk-test-only branch September 24, 2024 18:15
@release-please release-please bot mentioned this pull request Sep 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cindy-peng cindy-peng cindy-peng approved these changes

Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/java-datastore API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimit-j-shah @cindy-peng