Skip to content

feat: Upgrade protobuf gen code to 4.33 #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blakeli0 merged 3 commits into from
Dec 16, 2025
Merged

feat: Upgrade protobuf gen code to 4.33 #2019

blakeli0 merged 3 commits into from
Dec 16, 2025

Conversation

@diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented Dec 15, 2025 •
edited by cloud-java-bot
Loading

BEGIN_COMMIT_OVERRIDE
BEGIN_NESTED_COMMIT
fix(deps): update the Java code generator (gapic-generator-java) to 2.65.0-rc1
END_NESTED_COMMIT
END_COMMIT_OVERRIDE

@diegomarquezp diegomarquezp requested review from a team as code owners December 15, 2025 18:22
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: datastore Issues related to the googleapis/java-datastore API. labels Dec 15, 2025
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: xs Pull request size is extra small. labels Dec 15, 2025
@generated-files-bot
Copy link

generated-files-bot bot commented Dec 15, 2025

Warning: This pull request is touching the following templated files:

  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/AllocateIdsRequest.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/AllocateIdsRequestOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/AllocateIdsResponse.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/AllocateIdsResponseOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ArrayValue.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ArrayValueOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/BeginTransactionRequest.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/BeginTransactionRequestOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/BeginTransactionResponse.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/BeginTransactionResponseOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/CommitRequest.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/CommitRequestOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/CommitResponse.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/CommitResponseOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/CompositeFilter.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/CompositeFilterOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/DatastoreProto.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/Entity.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/EntityOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/EntityProto.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/EntityResult.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/EntityResultOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/Filter.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/FilterOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/GqlQuery.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/GqlQueryOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/GqlQueryParameter.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/GqlQueryParameterOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/Key.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/KeyOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/KindExpression.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/KindExpressionOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/LookupRequest.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/LookupRequestOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/LookupResponse.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/LookupResponseOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/Mutation.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/MutationOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/MutationResult.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/MutationResultOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/PartitionId.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/PartitionIdOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/Projection.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ProjectionOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/PropertyFilter.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/PropertyFilterOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/PropertyOrder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/PropertyOrderOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/PropertyReference.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/PropertyReferenceOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/Query.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/QueryOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/QueryProto.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/QueryResultBatch.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/QueryResultBatchOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ReadOptions.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ReadOptionsOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ReserveIdsRequest.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ReserveIdsRequestOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ReserveIdsResponse.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ReserveIdsResponseOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/RollbackRequest.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/RollbackRequestOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/RollbackResponse.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/RollbackResponseOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/RunQueryRequest.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/RunQueryRequestOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/RunQueryResponse.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/RunQueryResponseOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/TransactionOptions.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/TransactionOptionsOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/Value.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ValueOrBuilder.java

blakeli0
blakeli0 reviewed Dec 16, 2025
View reviewed changes
Copy link
Contributor

@blakeli0 blakeli0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the title and description to make it clear that this is intended to be a protobuf 4.33 gen code upgrade?

@diegomarquezp diegomarquezp changed the title feat: update generator version feat: Upgrade protobuf gen code to 4.33 Dec 16, 2025
@blakeli0 blakeli0 merged commit c783809 into protobuf-4.x-rc Dec 16, 2025
23 of 24 checks passed
@blakeli0 blakeli0 deleted the protobuf-4.x-update-gencode branch December 16, 2025 20:20
@release-please release-please bot mentioned this pull request Dec 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

Assignees

No one assigned

Labels

api: datastore Issues related to the googleapis/java-datastore API. size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@diegomarquezp @blakeli0 @cloud-java-bot