-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ReadOption.ReadTime to support timestamp reads. #712
Merged
gcf-merge-on-green
merged 10 commits into
googleapis:main
from
yixiaoshen:ys-snapshot-read-v1
May 23, 2022
Merged
feat: add ReadOption.ReadTime to support timestamp reads. #712
gcf-merge-on-green
merged 10 commits into
googleapis:main
from
yixiaoshen:ys-snapshot-read-v1
May 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
Pull request size is medium.
api: datastore
Issues related to the googleapis/java-datastore API.
labels
Apr 18, 2022
kolea2
reviewed
Apr 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, can we also add an integration test?
kolea2
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Apr 21, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Apr 21, 2022
kolea2
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
May 12, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
May 12, 2022
kolea2
requested changes
May 12, 2022
google-cloud-datastore/src/main/java/com/google/cloud/datastore/ReadOption.java
Show resolved
Hide resolved
kolea2
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
May 19, 2022
yoshi-kokoro
removed
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
labels
May 19, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
May 23, 2022
kolea2
approved these changes
May 23, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
May 23, 2022
kolea2
added
the
automerge
Merge the pull request once unit tests and other checks pass.
label
May 23, 2022
gcf-merge-on-green
bot
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
May 23, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 23, 2022
🤖 I have created a release *beep* *boop* --- ## [2.5.0](v2.4.0...v2.5.0) (2022-05-23) ### Features * add build scripts for native image testing in Java 17 ([#1440](#1440)) ([#739](#739)) ([252a174](252a174)) * add ReadOption.ReadTime to support timestamp reads. ([#712](#712)) ([06bb08f](06bb08f)) ### Bug Fixes * **java:** rename test to be picked up by native profile ([#723](#723)) ([3a30e75](3a30e75)) ### Documentation * **samples:** remove unused dependency ([#730](#730)) ([5185691](5185691)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.11.0 ([#737](#737)) ([8eb0c5f](8eb0c5f)) * update shared deps to 2.12.0 ([#740](#740)) ([5c3676e](5c3676e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: datastore
Issues related to the googleapis/java-datastore API.
size: m
Pull request size is medium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.