Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Use GsonFactory as JsonFactory implementation #779

Closed
Capstan opened this issue Jun 23, 2022 · 1 comment · Fixed by #780
Closed

Chore: Use GsonFactory as JsonFactory implementation #779

Capstan opened this issue Jun 23, 2022 · 1 comment · Fixed by #780
Labels
api: datastore Issues related to the googleapis/java-datastore API. type: cleanup An internal cleanup or hygiene concern.

Comments

@Capstan
Copy link
Contributor

Capstan commented Jun 23, 2022

For a variety of reasons, mostly to do with historical security issues, the monorepo and Google security prefers Gson to Jackson, and thus GsonFactory to JacksonFactory. Pushing this change upstream in lieu of patching the monorepo import.
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/java-datastore API. label Jun 23, 2022
@Capstan Capstan mentioned this issue Jun 23, 2022
Merged
@meredithslota
Copy link

(Related internal issue for maintainers b/216657461 for a different library, for additional context.)

@meredithslota meredithslota added the type: cleanup An internal cleanup or hygiene concern. label Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/java-datastore API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: Convert from JacksonFactory to GsonFactory Capstan/java-datastore
2 participants
@Capstan @meredithslota