Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(sample): Add a top-level Datastore samples README #790

Merged
merged 2 commits into from
Jul 19, 2022
Merged

docs(sample): Add a top-level Datastore samples README #790

merged 2 commits into from
Jul 19, 2022

Conversation

rwhogg
Copy link
Contributor

@rwhogg rwhogg commented Jul 6, 2022

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea. Issue already existed
  • Ensure the tests and linter pass N/A
  • Code coverage does not decrease (if any source code was changed) N/A
  • Appropriate docs were updated (if necessary) Strictly a docs addition

Fixes #745 ☕️

Note: I can confirm that the existing pom.xml works correctly.

@rwhogg rwhogg requested review from a team as code owners July 6, 2022 17:37
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: datastore Issues related to the googleapis/java-datastore API. samples Issues that are directly related to samples. labels Jul 6, 2022
lesv
lesv approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider the comment

samples/README.md Outdated Show resolved Hide resolved
@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 13, 2022
@kolea2 kolea2 added the automerge Merge the pull request once unit tests and other checks pass. label Jul 13, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 13, 2022
@kolea2 kolea2 removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 13, 2022
kolea2
kolea2 requested changes Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one last comment on thread

@rwhogg
docs(sample): Add a top-level Datastore samples README
0deb8be 
Explain how to run the TaskList sample
@kolea2 kolea2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 19, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 19, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 19, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit d3884dc into googleapis:main Jul 19, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 19, 2022
@release-please release-please bot mentioned this pull request Jul 19, 2022
Merged
@rwhogg rwhogg deleted the add-sample-readme branch July 19, 2022 16:38
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 9, 2022
@release-please
chore(main): release 2.11.0 (#801)
e271a1c 
🤖 I have created a release *beep* *boop*
---


## [2.11.0](v2.10.1...v2.11.0) (2022-08-04)


### Features

* add database_id field ([#802](#802)) ([6ed09dd](6ed09dd))


### Documentation

* **sample:** Add a top-level Datastore samples README ([#790](#790)) ([d3884dc](d3884dc))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#805](#805)) ([ad467ef](ad467ef))
* update dependency com.google.errorprone:error_prone_core to v2.15.0 ([#810](#810)) ([fc8cd15](fc8cd15))
* update dependency org.junit.vintage:junit-vintage-engine to v5.9.0 ([#804](#804)) ([6caafd8](6caafd8))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolea2 kolea2 kolea2 approved these changes

@lesv lesv lesv approved these changes

Assignees

@lesv lesv

Labels
api: datastore Issues related to the googleapis/java-datastore API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What are the steps to run samples/snippets/src/main/java/com/google/datastore/snippets/TaskList.java ?
4 participants
@rwhogg @lesv @kolea2 @yoshi-kokoro