Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Sum and Average aggregations #1387

Merged
merged 14 commits into from
Oct 9, 2023
Merged

feat: Sum and Average aggregations #1387

merged 14 commits into from
Oct 9, 2023

Conversation

ehsannas
Copy link
Contributor

@ehsannas ehsannas commented Aug 2, 2023

No description provided.

ehsannas added 2 commits August 2, 2023 15:42
@ehsannas
feat: SUM / AVG (#1218)
8cde315 
* feat: SUM / AVG (real files)

* Remove aggregate field duplicates (if any).

* Clean up and fixes.

* Clean up comments, and add Nonnull where possible.

* Add more public docs.

* More cleanup.

* Update hashCode and equals for AggregateQuery.

* Address code review comments. more to come.

* fix test name.

* Better comment.

* Fix alias encoding.

* Remove TODO.

* Revert the way alias is constructed.

* Backport test updates.

fix format.

fix import stmt.
@ehsannas
feat: Add long alias support for aggregations. (#1267)
8cdcf54 
* feat: Add long alias support for aggregations.

* address comments.

* Better method name and replace hardcoded "count" with "aggregate_0".

* Remove duplicate aggregations.

* add static import.

* Fix tests. All tests pass.
@ehsannas ehsannas self-assigned this Aug 2, 2023
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: firestore Issues related to the googleapis/java-firestore API. labels Aug 2, 2023
@ehsannas ehsannas added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 2, 2023
@ehsannas ehsannas changed the title feat: SUM and Average aggregations feat: Sum and Average aggregations Aug 2, 2023
@ehsannas ehsannas assigned MarkDuckworth and unassigned ehsannas Aug 2, 2023
@ehsannas ehsannas requested a review from MarkDuckworth August 2, 2023 23:16
MarkDuckworth
MarkDuckworth reviewed Aug 8, 2023
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Javadoc needs to be added for AggregateField and there's a test config still pointing to the emulator. Otherwise, it looks good to me.

google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITQueryAggregationsTest.java Outdated Show resolved Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/AggregateField.java Show resolved Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITQueryAggregationsTest.java Outdated Show resolved Hide resolved
MarkDuckworth
MarkDuckworth approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can land as in, but as you mentioned, we could add additional return type info to javadoc on the AggregateField class to improve this. If there are further updates, I'm happy to take a look.

@ehsannas ehsannas marked this pull request as ready for review September 26, 2023 22:42
@ehsannas ehsannas requested a review from a team as a code owner September 26, 2023 22:42
@ehsannas ehsannas added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 2, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 2, 2023
@ehsannas ehsannas removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 2, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner October 2, 2023 22:35
MarkDuckworth
MarkDuckworth approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehsannas ehsannas added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 3, 2023
@ehsannas ehsannas added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Oct 5, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2023
MarkDuckworth
MarkDuckworth approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehsannas ehsannas merged commit afa5c01 into main Oct 9, 2023
18 checks passed
@ehsannas ehsannas deleted the ehsann/sum-average-release branch October 9, 2023 17:15
@release-please release-please bot mentioned this pull request Oct 9, 2023
Merged
cherylEnkidu pushed a commit that referenced this pull request Dec 11, 2023
@ehsannas @gcf-owl-bot @cherylEnkidu
feat: Sum and Average aggregations (#1387)
0d2a380 
* feat: SUM / AVG (#1218)

* feat: SUM / AVG (real files)

* Remove aggregate field duplicates (if any).

* Clean up and fixes.

* Clean up comments, and add Nonnull where possible.

* Add more public docs.

* More cleanup.

* Update hashCode and equals for AggregateQuery.

* Address code review comments. more to come.

* fix test name.

* Better comment.

* Fix alias encoding.

* Remove TODO.

* Revert the way alias is constructed.

* Backport test updates.

fix format.

fix import stmt.

* feat: Add long alias support for aggregations. (#1267)

* feat: Add long alias support for aggregations.

* address comments.

* Better method name and replace hardcoded "count" with "aggregate_0".

* Remove duplicate aggregations.

* add static import.

* Fix tests. All tests pass.

* Address comments.

* Improve the documentation to match strongly typed languages.

* Do not use wildcard import.

* Do not use wildcard import (2).

* Do not use wildcard import (3).

* Do not use wildcard import (4).

* Fix the javadoc.

* Add license header, and remove unused test code.

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* better regex.

* Add more tests for cursors.

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@release-please release-please bot mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-andersen tom-andersen tom-andersen left review comments

@markarndt markarndt markarndt approved these changes

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

Assignees

@MarkDuckworth MarkDuckworth

Labels
api: firestore Issues related to the googleapis/java-firestore API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ehsannas @MarkDuckworth @tom-andersen @markarndt @yoshi-kokoro