-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Logical termination for firestore.getAll(...). #1517
Conversation
This improves the performance for 2 cases: (1)
we know we expect 3 responses, so we can return the result after we receive 3 docs. (2)
This simply calls (b/309863147) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Ehsan, I change the unit tests to verify the changes. Please only merge the PR If my changes look good to you,
…ot run with logical termination
Hi @ehsannas , please verify my latest fix before merging the PR. Thank you! |
No description provided.