-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add additional Firestore query snippets #1790
Conversation
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
It looks like Kokoro sample tests failed with:
Not super familiar with firestore, do we need to create an index? https://cloud.google.com/firestore/docs/query-data/indexing |
...ets/src/main/java/com/example/firestore/snippets/MultipleRangeInequalityFiltersSnippets.java
Outdated
Show resolved
Hide resolved
...s/src/test/java/com/example/firestore/snippets/MultipleRangeInequalityFiltersSnippetsIT.java
Outdated
Show resolved
Hide resolved
...ets/src/main/java/com/example/firestore/snippets/MultipleRangeInequalityFiltersSnippets.java
Show resolved
Hide resolved
Created new indexes for the sample build! Kokoro build passes now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, this is Jia from Firestore. Thanks for making the change!
Hi @kevkim-codes , still missing the Datastore version with region tag: datastore_query_filter_compound_multi_ineq |
Creates a region tag to use for documentation: Docsite page: https://firebase.google.com/docs/firestore/query-data/multiple-range-fields