fix: Drop the setTracingEnabled flag from Options (@BetaApi change) #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
ehsannas
force-pushed
the
ehsann/drop-tracing-enable-flag
branch
from
b50f823 to
c0c912d
Compare
ehsannas
added
the
do not merge
milaGGL
reviewed
Oct 8, 2024
google-cloud-firestore/src/main/java/com/google/cloud/firestore/telemetry/TraceUtil.java
Show resolved
Hide resolved
milaGGL
reviewed
Oct 8, 2024
google-cloud-firestore/src/main/java/com/google/cloud/firestore/AggregateQuery.java
Show resolved
Hide resolved
milaGGL
reviewed
Oct 8, 2024
google-cloud-firestore/src/main/java/com/google/cloud/firestore/telemetry/EnabledTraceUtil.java
Show resolved
Hide resolved
milaGGL
reviewed
Oct 8, 2024
google-cloud-firestore/src/main/java/com/google/cloud/firestore/telemetry/EnabledTraceUtil.java
Show resolved
Hide resolved
milaGGL
approved these changes
Oct 9, 2024
milaGGL
reviewed
Nov 1, 2024
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITE2ETracingTest.java
Show resolved
Hide resolved
ehsannas
removed
the
do not merge
ehsannas
changed the title
ehsannas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the deprecated
setTracingEnabled()API is redundant and is being removed.Firestore SDK will use the OpenTelemetry instance passed to it. In its absence, it will use the Global OpenTelemetry by default. There is no need to enable tracing via the
setTracingEnabled()API. If the user wants to disable tracing, they can still do so by providing a no-op OpenTelemetry instance or by usingFIRESTORE_ENABLE_TRACING=OFFenv var.