Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Java Pubsub Issues to Check #1539

Closed
maitrimangal opened this issue Apr 3, 2023 · 1 comment
Closed

Spring Java Pubsub Issues to Check #1539

maitrimangal opened this issue Apr 3, 2023 · 1 comment
Labels
api: pubsub Issues related to the googleapis/java-pubsub API.

Comments

@maitrimangal
Copy link
Member

  1. min-duration-per-ack-extension and max-duration-per-ack-extension can equal each other in spring java pubsub
  2. Check what the default values of 0 mean - whether it is not set completely or if it equals zero.
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Apr 3, 2023
@maitrimangal
Copy link
Member Author

  1. Currently there is no validation done for the min, and max, so setting minDurationPerAckExtension and maxDurationPerAckExtension equal is valid in Spring Cloud GCP, but this setting is invalid when passing to the sever side.

  2. The default value is actually set to null, however this value was not changed in the docs because it seems like a lot of the default values in the docs are not what they actually are in the code. For reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/java-pubsub API.
Projects
None yet
Development

No branches or pull requests

1 participant