Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

docs(samples): Refactoring product package (Import) (new) #480

Merged
merged 29 commits into from
Sep 13, 2022

Conversation

dfirova
Copy link
Contributor

@dfirova dfirova commented Jul 1, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@dfirova dfirova requested a review from a team as a code owner July 1, 2022 08:07
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jul 1, 2022
@google-cla
Copy link

google-cla bot commented Jul 1, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added api: retail Issues related to the googleapis/java-retail API. samples Issues that are directly related to samples. labels Jul 1, 2022
@dfirova dfirova requested review from a team as code owners July 1, 2022 08:10
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xs Pull request size is extra small. labels Jul 1, 2022
@eaball35 eaball35 assigned meltsufin and unassigned eaball35 Jul 11, 2022
@dfirova dfirova requested a review from chenlei1216 July 19, 2022 05:23
@dfirova dfirova requested a review from chenlei1216 July 20, 2022 05:33
@alicejli alicejli added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 22, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 22, 2022
@alicejli alicejli closed this Aug 22, 2022
@alicejli alicejli reopened this Aug 22, 2022
@dfirova
Copy link
Contributor Author

dfirova commented Aug 24, 2022

@alicejli , I don't have permission to see the details of owlbot failed run, would appreciate the details on this issue.

@alicejli
Copy link

Looks like some permissions issue on some changes owlbot was trying to run:

Step #8: Status: Downloaded newer image for gcr.io/cloud-devrel-public-resources/owlbot-cli:latest
Step #8: gcr.io/cloud-devrel-public-resources/owlbot-cli:latest
Step #8: git add -A .
Step #8: git status . --porcelain
Step #8: Retrieving PR info for googleapis/java-retail
Step #8: Retrieved PR info for googleapis/java-retail
Step #8: git log -1 --format=%B
Step #8: git commit -m "🦉 Updates from OwlBot post-processor
Step #8: 
Step #8: See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md"
Step #8: git pull --no-verify
Step #8: git push --no-verify
Step #8: To https://github.com/dfirova/java-retail.git
Step #8:  ! [remote rejected] refactoring-products-import -> refactoring-products-import (permission denied)
Step #8: error: failed to push some refs to 'https://github.com/dfirova/java-retail.git'
Step #8: owl-bot.js commit-post-processor-update
Step #8: 
Step #8: Runs either `git commit -m "Updates from OwlBot"` or `git commit --amend
Step #8: --no-edit`
Step #8: depending on the squash flag in .OwlBot.yaml.
Step #8: 
Step #8: Run this command in the root directory of a client library repository after
Step #8: running the post processor.
Step #8: 
Step #8: Options:
Step #8:   --help          Show help                                            [boolean]
Step #8:   --version       Show version number                                  [boolean]
Step #8:   --dest-repo     The PR's destination repo (e.g., googleapis/foo)
Step #8:                                                              [string] [required]
Step #8:   --pr            The pull request number                    [number] [required]
Step #8:   --github-token  Short-lived GitHub token.                  [string] [required]
Step #8:   --repo-path     Local path to the repository
Step #8:                                     [string] [default: "/workspace/java-retail"]
Step #8: 
Step #8: Error: Command failed: git push --no-verify
Step #8: To https://github.com/dfirova/java-retail.git
Step #8:  ! [remote rejected] refactoring-products-import -> refactoring-products-import (permission denied)
Step #8: error: failed to push some refs to 'https://github.com/dfirova/java-retail.git'
Step #8: 
Step #8:     at checkExecSyncError (child_process.js:790:11)
Step #8:     at Object.execSync (child_process.js:863:15)
Step #8:     at cmd (/usr/src/app/build/src/cmd.js:44:29)
Step #8:     at commitPostProcessorUpdate (/usr/src/app/build/src/bin/commands/commit-post-processor-update.js:146:5)
Step #8:     at processTicksAndRejections (internal/process/task_queues.js:95:5) {
Step #8:   status: 1,
Step #8:   signal: null,
Step #8:   output: [
Step #8:     null,
Step #8:     <Buffer >,
Step #8:     <Buffer 54 6f 20 68 74 74 70 73 3a 2f 2f 67 69 74 68 75 62 2e 63 6f 6d 2f 64 66 69 72 6f 76 61 2f 6a 61 76 61 2d 72 65 74 61 69 6c 2e 67 69 74 0a 20 21 20 5b ... 176 more bytes>
Step #8:   ],
Step #8:   pid: 43,
Step #8:   stdout: <Buffer >,
Step #8:   stderr: <Buffer 54 6f 20 68 74 74 70 73 3a 2f 2f 67 69 74 68 75 62 2e 63 6f 6d 2f 64 66 69 72 6f 76 61 2f 6a 61 76 61 2d 72 65 74 61 69 6c 2e 67 69 74 0a 20 21 20 5b ... 176 more bytes>
Step #8: }
Finished Step #8

I think this happens when an update to a PR is made after an OwlBot post processor is already running. Try doing a git pull and see if there's any changes that need to be rebased before doing a git push to retrigger.

@alicejli alicejli added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 26, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 26, 2022
@Shabirmean Shabirmean added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 29, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 29, 2022
@dfirova
Copy link
Contributor Author

dfirova commented Aug 31, 2022

@yoshi-kokoro please trigger Kokoro checks.

@dfirova
Copy link
Contributor Author

dfirova commented Sep 8, 2022

@chenlei1216 , the tests haven't been triggered in over a week, kindly ask to trigger them

@chenlei1216 chenlei1216 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 8, 2022
@chenlei1216
Copy link

@chenlei1216 , the tests haven't been triggered in over a week, kindly ask to trigger them

Triggerred.

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 8, 2022
@kurtisvg kurtisvg merged commit 0c39897 into googleapis:main Sep 13, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 16, 2022
🤖 I have created a release *beep* *boop*
---


## [2.5.0](v2.4.0...v2.5.0) (2022-09-16)


### Features

* add local inventories info to the Product resource ([8204fbc](8204fbc))
* release AttributesConfig APIs to v2 version ([8204fbc](8204fbc))
* release CompletionConfig APIs to v2 version ([8204fbc](8204fbc))
* Release Control and ServingConfig serivces to v2 version ([#522](#522)) ([8204fbc](8204fbc))


### Bug Fixes

* **samples:** Removed add time from lro. ([#530](#530)) ([541e280](541e280))
* **samples:** Removed env variables and buckets from creating bq. ([#526](#526)) ([67152a6](67152a6))
* **samples:** Removed region tags ([#531](#531)) ([2d0dd5c](2d0dd5c))


### Documentation

* Improved documentation for Fullfillment and Inventory API in ProductService ([8204fbc](8204fbc))
* minor documentation format and typo fixes ([8204fbc](8204fbc))
* **samples:** Refactoring events package ([#481](#481)) ([20d2539](20d2539))
* **samples:** Refactoring product package ([#480](#480)) ([0c39897](0c39897))


### Dependencies

* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.5 ([#503](#503)) ([435df1b](435df1b))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.6 ([#519](#519)) ([9c37ee3](9c37ee3))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.7 ([#523](#523)) ([0da80f8](0da80f8))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.15.0 ([#524](#524)) ([ecb986a](ecb986a))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.16.0 ([#535](#535)) ([e7fa004](e7fa004))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#533](#533)) ([6236b06](6236b06))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#538](#538)) ([ab71781](ab71781))
* Update dependency com.google.cloud:google-cloud-storage to v2.11.3 ([#511](#511)) ([364b3d4](364b3d4))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit to meltsufin/monorepo-experiments that referenced this pull request Sep 17, 2022
🤖 I have created a release *beep* *boop*
---


## [2.5.0](googleapis/java-retail@v2.4.0...v2.5.0) (2022-09-16)


### Features

* add local inventories info to the Product resource ([32a384d](googleapis/java-retail@32a384d))
* release AttributesConfig APIs to v2 version ([32a384d](googleapis/java-retail@32a384d))
* release CompletionConfig APIs to v2 version ([32a384d](googleapis/java-retail@32a384d))
* Release Control and ServingConfig serivces to v2 version ([#522](googleapis/java-retail#522)) ([32a384d](googleapis/java-retail@32a384d))


### Bug Fixes

* **samples:** Removed add time from lro. ([#530](googleapis/java-retail#530)) ([858b0e1](googleapis/java-retail@858b0e1))
* **samples:** Removed env variables and buckets from creating bq. ([#526](googleapis/java-retail#526)) ([eeb68fa](googleapis/java-retail@eeb68fa))
* **samples:** Removed region tags ([#531](googleapis/java-retail#531)) ([b12a8fe](googleapis/java-retail@b12a8fe))


### Documentation

* Improved documentation for Fullfillment and Inventory API in ProductService ([32a384d](googleapis/java-retail@32a384d))
* minor documentation format and typo fixes ([32a384d](googleapis/java-retail@32a384d))
* **samples:** Refactoring events package ([#481](googleapis/java-retail#481)) ([c644df0](googleapis/java-retail@c644df0))
* **samples:** Refactoring product package ([#480](googleapis/java-retail#480)) ([aebf241](googleapis/java-retail@aebf241))


### Dependencies

* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.5 ([#503](googleapis/java-retail#503)) ([58a7105](googleapis/java-retail@58a7105))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.6 ([#519](googleapis/java-retail#519)) ([dc52906](googleapis/java-retail@dc52906))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.7 ([#523](googleapis/java-retail#523)) ([3ad9ecf](googleapis/java-retail@3ad9ecf))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.15.0 ([#524](googleapis/java-retail#524)) ([2b6c293](googleapis/java-retail@2b6c293))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.16.0 ([#535](googleapis/java-retail#535)) ([826cbd6](googleapis/java-retail@826cbd6))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#533](googleapis/java-retail#533)) ([29807c8](googleapis/java-retail@29807c8))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#538](googleapis/java-retail#538)) ([e4170e8](googleapis/java-retail@e4170e8))
* Update dependency com.google.cloud:google-cloud-storage to v2.11.3 ([#511](googleapis/java-retail#511)) ([2c435e5](googleapis/java-retail@2c435e5))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: retail Issues related to the googleapis/java-retail API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.