-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Types.BOOLEAN and Types.BIT should have identical behaviour for nullability #920
fix: Types.BOOLEAN and Types.BIT should have identical behaviour for nullability #920
Conversation
…bility. In master, BOOLEAN is nullable but BIT will throw IllegalArgumentException if an attempt is made to set a null value.
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…nullability. In master, BOOLEAN is nullable but BIT will throw IllegalArgumentException if an attempt is made to set a null value.
…panner-jdbc into bug-nullable_bit_type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Adding @olavloite to take a look as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🤖 I have created a release *beep* *boop* --- ## [2.7.7](v2.7.6...v2.7.7) (2022-09-16) ### Bug Fixes * Types.BOOLEAN and Types.BIT should have identical behaviour for nullability ([#920](#920)) ([42e5903](42e5903)) ### Dependencies * Google-cloud-spanner-bom 6.30.0 ([#967](#967)) ([9385a5d](9385a5d)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#963](#963)) ([811d96b](811d96b)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#966](#966)) ([f8b88cd](f8b88cd)) * Update dependency com.google.cloud:google-cloud-spanner-bom to v6.29.0 ([#943](#943)) ([9754023](9754023)) * Update dependency com.google.cloud:google-cloud-spanner-bom to v6.29.1 ([#961](#961)) ([a3e1fc6](a3e1fc6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Types.BOOLEAN and Types.BIT should have identical behaviour for nullability. In master, BOOLEAN is nullable but BIT will throw IllegalArgumentException if an attempt is made to set a null value.
Fixes #919